search

laike9m / pdir2

Pretty dir() printing with joy:beer:
MIT License
1.33k stars 47 forks source link

Drop support for Python 2 #75

Closed aqeelat closed 1 year ago

aqeelat commented 1 year ago

I would like to work on this issue

laike9m commented 1 year ago

Sure, feel free to do so. It should mostly be cleanup work. Thanks!

laike9m commented 1 year ago

The code base is using type hints that only exist in Python 3.5+, so it could be that it's already done. Having said that, doing a thorough check (e.g. tests) and close this bug is definitely worth it.

aqeelat commented 1 year ago

I see that you set requires-python = ">=3.8" but I guess I got confused when I saw the python 2 classifier.

Anyhow, I will cleanup the classifiers and run pyupgrade on the repo and open a PR for that.

laike9m commented 1 year ago

pdir2 supports Python 2 (in earlier versions) thus the classifier. I guess you can remove it.