lainsce / timetable

[DEPRECATED] Plot out your own timetable for the week and organize it
GNU General Public License v3.0
6 stars 3 forks source link

Use Granite.MessageDialog instead of Gtk.MessageDialog #11

Closed ryonakano closed 5 years ago

ryonakano commented 5 years ago

Before

screenshot from 2018-10-28 12-09-57

After

screenshot from 2018-10-28 22-42-00

Changes Summary

I'm worried that the "Save" button in the MessageDialog is not focused when the dialog is shown, because if users press Enter key wrongly without switching the focus, they should lose their timetable. But I'm not sure how to bring the focus to the "Save" button, would it be possible for you to tell me how?

lainsce commented 5 years ago

I think you can override focus, but I'd need to research in Valadocs. I'll edit this comment with the process later. As for the primary text, can you remove the "Do You Want" part so it says "Save changes to the Timetable?" ?

ryonakano commented 5 years ago

Addressed

ryonakano commented 5 years ago

@lainsce Searching in Valadoc more deeply, I've found how to set focus to the save button by default !! I addressed it in ce878ad2b06ffab0b639a915fcdd809202ed042c

lainsce commented 5 years ago

All lookin' good! Merged!