lairworks / nas2d-core

NAS2D is an open source, object oriented 2D game development framework written in portable C++.
http://nas2d.lairworks.com
zlib License
10 stars 5 forks source link

Update Linux Docker images #1070

Closed DanRStevens closed 2 years ago

DanRStevens commented 2 years ago

Update the Linux Docker images to make them more usable in different environments. In particular, make them compatible for use with GitHub Actions runners. This means not specifying USER or WORKDIR in the Dockerfile. Instead, pass those parameters on the command line at startup for local use with the makefile, or let the CircleCI and GitHub Actions environments specify their own values at startup.

It should be noted that passing in the uid and gid of the current user also makes the Docker images more broadly usable in local environments. Previously the images would always run with a uid of 1000, which matched the first user on many Linux distributions, such as Ubuntu, but would not match any subsequent local users added to the system, nor distributions that started local user numbering at a different value. That used to cause files build in the Docker images to be owned by a different user in the build output folder. The new behavior of matching the uid and gid to the user running the makefile on the host system is much more convenient.

Reference: #682