laiso / site2pdf

Generate comprehensive PDFs of entire websites, ideal for RAG.

MIT License

168 stars 8 forks source link

Concurrency Control and Dependency Injection in Testing #1

Closed laiso closed 3 months ago

laiso commented 3 months ago

Concurrency Control:

Added browser and concurrentLimit parameters to the generatePDF function.
Implemented parallel processing control using p-limit.

https://github.com/laiso/site2pdf/blob/a48ceacb2ec43f516506c7a12173c32cd1bf40a1/index.ts#L10-L16

Test Improvements:

Added tests for the generatePDF function using a mock browser.
Injected puppeteer dependency.
Added fixture.pdf as a new fixture file.
Set up and restored console.log mocks before and after tests.

https://github.com/laiso/site2pdf/blob/a48ceacb2ec43f516506c7a12173c32cd1bf40a1/index.test.ts#L17-L26

This enhances the PDF generation logic, improves testability, and adds concurrency control.