Closed GoogleCodeExporter closed 9 years ago
Yeah, I agree that it would be better to have a TreeFeature subclass of
Feature, and TreeFeatureVectorFeaturesEncoder could simply check for that with
instanceof. Classifiers that don't use tree kernels would just use the regular
string value of the feature (like they do now).
Original comment by steven.b...@gmail.com
on 3 May 2013 at 11:45
Here is a patch implementing this fix.
Original comment by tim.mil...@gmail.com
on 11 May 2013 at 7:12
Attachments:
The patch looks good. It needs a unit test though. (We try to add a unit test
with every commit.)
Original comment by steven.b...@gmail.com
on 12 May 2013 at 1:43
This issue was closed by revision 18c46b6303b1.
Original comment by tim.mil...@gmail.com
on 13 May 2013 at 1:41
Original issue reported on code.google.com by
tim.mil...@gmail.com
on 3 May 2013 at 11:16