password contains @

[Meaningisuse]

[laixintao]

Ha! never thought about that case! thanks, will fix later.

[laixintao]

Hi @Meaningisuse after checking from the code, I found it should handle the case that password containing @, maybe the @ is not the issue? can see https://github.com/laixintao/iredis/pull/488/files , I add a test case and it passed.

can you give me a full alias_dsn line that can reproduce your issue? so I can reproduce then fix it. (please don't give me your real password, can fake one or change some characters of the domain and password of this one)

thanks.

[Meaningisuse]

Hi @Meaningisuse after checking from the code, I found it should handle the case that password containing @, maybe the @ is not the issue? can see https://github.com/laixintao/iredis/pull/488/files , I add a test case and it passed.

can you give me a full alias_dsn line that can reproduce your issue? so I can reproduce then fix it. (please don't give me your real password, can fake one or change some characters of the domain and password of this one)

thanks.

[alias_dsn] test=redis://030b5bdf-7b61-4101-a7a8-a891b9beba65@Hr1FJTRi7bDLcPQa@audit.test.com:30265/2

[laixintao]

Oh I saw the issue now: the : can not be eliminated:

If you only have password, write like this:

test=redis://:030b5bdf-7b61-4101-a7a8-a891b9beba65@Hr1FJTRi7bDLcPQa@audit.test.com:30265/2

without : the url parser is confused, it would think the whole line is a domain.

https://github.com/laixintao/iredis/blob/master/iredis/data/iredisrc#L83

[laixintao]

Hi @Meaningisuse I am going to close this issue as this is not a bug, feel free to reopen if you still have issues ;D