search

laixintao / iredis

Interactive Redis: A Terminal Client for Redis with AutoCompletion and Syntax Highlighting.
https://iredis.xbin.io
BSD 3-Clause "New" or "Revised" License
2.52k stars 102 forks source link

remove pendulum #492

Closed deronnax closed 3 months ago

deronnax commented 3 months ago

As it is a pain: pendulum 2 is incompatible with python 3.12 and pendulum 3 has strange build errors we do not understand. The package has governance problems were the sole maintainer won't address problems, and more problematically, won't even answer to questions, see https://github.com/sdispater/pendulum/discussions/771.

Python-dateutil is a more reliable package to rely on: it's been around for longer, is not a one-person project and the founder is now a python core-maintainer in charge of the datetime module.

deronnax commented 3 months ago

it looks pendulum.parse for a date assumes UTC, so I had to force UTC timezone on datetime.fromisoformat. I doubt this is a good thing and I think the python datetime module knows better than pendulum, but @laixintao you have the final say.

deronnax commented 3 months ago

We can't simply remove python-dateutil (but it's not an addition: it was already used underneath by pendulum). Iredis would not be able to do good future/past completion in time without it, thanks to its superior relativedelta.

laixintao commented 3 months ago

Thank you so so much!

laixintao commented 3 months ago

Released v1.15.0

deronnax commented 3 months ago

You're welcome. Thank you :)