lajax / yii2-translate-manager

Translation Manager
MIT License
227 stars 90 forks source link

LanguageSource::getLanguageTranslateByLanguage is not correct #43

Closed tonchik-tm closed 8 years ago

tonchik-tm commented 8 years ago

In lajax/yii2-translate-manager/controllers/actions/DialogAction.php:30

$languageSource->getLanguageTranslateByLanguage(Yii::$app->request->post('language_id', ''))->one()

But in lajax/yii2-translate-manager/models/LanguageSource.php:113

\lajax\translatemanager\models\LanguageSource::getLanguageTranslateByLanguage()

without parameter 'language_id' and return first item.

You can improve the method so that it returns the desired translation? Thank you

tonchik-tm commented 8 years ago

Example:

/**
     * @return \yii\db\ActiveQuery
     */
    public function getLanguageTranslateByLanguage($language=null)
    {
        if ($language)
            return $this->getLanguageTranslate()->where(['language'=>$language]);

        return $this->getLanguageTranslate();
    }
lajax commented 8 years ago

Thanks!