lajax / yii2-translate-manager

Translation Manager
MIT License
227 stars 90 forks source link

Added translation support for php files with javascript heredoc #62

Closed NickvdMeij closed 8 years ago

NickvdMeij commented 8 years ago

This code checks for 'lajax.t' function within PHP javascript heredocs. This allows for javascript translations within a php file.

lajax commented 8 years ago

Thanks for the PR but this solution is too specific

NickvdMeij commented 8 years ago

@lajax Then what would you like to see different? Because the company I work for would love to see such a feature (translating in heredocs and/or strings) implemented in the translate manager. If you point my in the right direction, I can make another pull request with a less "specific" implementation