search

lake-wg / edhoc

Ephemeral Diffie-Hellman Over COSE (EDHOC)
Other
7 stars 12 forks source link

Missing Responder private key in test vector. #42

Closed TimothyClaeys closed 3 years ago

TimothyClaeys commented 3 years ago

In the following test vector [method 2 - Static(Initiator)-Sign(Responder)]:

https://github.com/lake-wg/edhoc/blob/c73dc6affe2d7a47fa8eac97be4d4bbd8bd7c667/test-vectors/vectors.txt#L978

The Responder is missing its private authentication key. The Responder's private key is required to compute the sign_or_mac2part of message 2, using an COSE_Sign1 structure.

fpalombini commented 3 years ago

Again due to the copy paste typo in the generation code, now fixed in a09570b. Need to run the code to regenerate new test vectors using the updated code, I wouldn't update the appendix at the same time to match the vectors.txt though, because that's not really necessary (they are still correct, just need to fix the print).

emanjon commented 3 years ago

Fixed in test-vector-05