search

lake-wg / edhoc

Ephemeral Diffie-Hellman Over COSE (EDHOC)
Other
7 stars 12 forks source link

Traces: IESG Murray Kucherawy's comments #449

Closed emanjon closed 1 year ago

emanjon commented 1 year ago

I don't think you want BCP 14 here. The solitary "MUST" you do have is actually citing another document; this one is Informational and not actually stating any of its own requirements. I'd suggest removing the BCP 14 references and the matching boilerplate, but quote the "MUST" or even just say that document "requires" (lowercase) something specific.

emanjon commented 1 year ago

This was added based on the INTDIR review. I agree with INTDIR that we need BCP 14. There is a MUST NOT that is not citing another document.

The keys printed in these examples cannot be considered secret and MUST NOT be used.

Agree with Murray that we should reformulate the cited MUST.

Correct is the deterministic encoding 03 according to Section 3.1 of [I-D.ietf-lake-edhoc] and Section 4.2.1 of [RFC8949], which states that the arguments for integers, lengths in major types 2 through 5, and tags MUST be as short as possible.

gselander commented 1 year ago

Closed as completed.