#32 | Fix "access to private variable of parent class" in SkinLakeus.php

[MXP2095onetechguy]

SkinLakeus.php declaration fix.

This is my first time doing an actual pull request.

So, this is a fix to declare the $templateParser property in the SkinLakeus.php file, specifically the class.
This fix was created in response to a deprecation warning.

And if you are asking what MediaWiki am I running this on, here is a screenshot.

I am indeed running MediaWiki 1.41.0

[lakejason0]

@winstonsung help me

[lakejason0]

Somehow I couldn't reproduce this on my own site somehow. Checked similar codes and they declare these as private. I know nothing of PHP unfortunately so idk what's happening.

[MXP2095onetechguy]

The machine is a portable version of XAMPP on windows. This might help.

I don't really know a lot about php, just enough to fix tid-bits like this. This is just to fix the notice.

[lakejason0]

Searched on the web and it seems like it’s introduced in PHP 8.2; 8.1 is used on my site.

[winstonsung]

(Testing...)

[MXP2095onetechguy]

Let me fix the missing doc tags.

[MXP2095onetechguy]

Missing doc tag added.

[MXP2095onetechguy]

let me go back and fix those things reported by phpcs again.

[MXP2095onetechguy]

So, I fixed whatever was causing workflows to fail from what I know.

[winstonsung]

Thanks for the report!

Issue identified.

We could just drop the weird BagOStuff $localServerObjectCache dependency as it seems to be duplicated from Mirage skin without any clear reason.

Mirage skin used it for a configuration option for development purpose, but we don't have it here.

[winstonsung]

@MXP2095onetechguy

Please confirm whether this issue still exists in the latest commit. Thanks.

[MXP2095onetechguy]

@MXP2095onetechguy

Please confirm whether this issue still exists in the latest commit. Thanks.

I will try to do so ASAP.

[MXP2095onetechguy]

Problem solved.

[winstonsung]

Good to hear that.

Thanks for the confirmation.