lakenen / node-box-view

A node client for the Box View API
MIT License
13 stars 2 forks source link

File uploads broken on node 0.12 #19

Closed lakenen closed 9 years ago

lakenen commented 9 years ago

Upgrading deps didn't actually fix this. It seems to only hang on multipart uploads with documents larger than a certain size...

It also only happens when retry is true.

lakenen commented 9 years ago

It turns out this is only an issue when retry is true and the file upload is called with a stream or string filename (and thus a stream via fs.createReadStream).

After some thought, it makes a lot of sense, and the retry option simply cannot work with a stream.