lakesare / memcode

Spaced-repetition: with real formatting.
http://memcode.com
MIT License
330 stars 71 forks source link

Print out option is not intuitive #128

Closed Wehzie closed 2 years ago

Wehzie commented 2 years ago

Hello,

When opening the three-dot context menu and clicking the print out option, then a blank page with the course title is created in most common use scenarios. In order for the print page to display elements laborious steps need to be taken.

In creation mode it always seems to be the case that the print page is blank. Selecting QA pairs in creation mode doesn't change this behavior. Personally I would like to see a behavior that shows all cards on the print page when clicking the print option while in creation mode.

It seems that cards need to be manually selected to appear on the print page while in learning mode (there seems to be no select all option). While cards selected as learnt are persistent between sessions, they disappear from the print out page, therefore manually re-selecting each card is necessary for them to appear again. This is very laborious and a changed behavior would be desirable in my opinion.

Thank you :)

lakesare commented 2 years ago

Hi!

On the print page we're printing out the flashcards that are ready for review (see the text in white), the behaviour you described is very much expected:

image

We can add an option to print out either all flashcards, or only the flashcards to review if you'd like.

Wehzie commented 2 years ago

Thank you for clarification 🙏

What I did was add a card to learnt, then it was in review, then I reviewed it. And right after I tried to print. It didn't show up. Would this be because of spaced repetition? So in order for it to show I'd have to wait until it's in review again. I think print out all cards in a deck would be a good feature!

lakesare commented 2 years ago

Would this be because of spaced repetition?

Yup, the "print out" option is usually used by people who like to review their flashcards on paper.

Let's add this to TODOs.

piotrvidal commented 2 years ago

I can take this one @lakesare: so this would be just adding another option to the contextual menu that says

"Print All Out"
"Some description for example: Open a page suitable for printing all cards within this deck."

Or some other solution?

lakesare commented 2 years ago

@piotrvidal, nice! Yes, let's make this a separate list item for now, converting it to a modal e.g. will be easy.

lakesare commented 2 years ago

Resolved by https://github.com/lakesare/memcode/pull/151, thanks @piotrvidal!

Just deployed it, it's live on Memcode: image.

As always - don't forget to CMD+SHIFT+R to reset the cache.