Some of the users' avatars don't exist anymore.

lakesare / memcode

Spaced-repetition: with real formatting.

http://memcode.com

MIT License

335 stars 72 forks source link

Some of the users' avatars don't exist anymore. #49

Open lakesare opened 4 years ago

lakesare commented 4 years ago

Users sign up via github/google, and something the url to their avatars changes, which means we get this look:

[ ] As soon as user signs up - let's upload their avatar to our AWS S3, and store that link instead. We already have amazon credentials for AWS S3 storage, let's use those.
[ ] We should also create a script that refetches stale user images from their Google and Github accounts.

anandvenkat4 commented 4 years ago

Instead, why don't we update the avatar each time they login?

lakesare commented 4 years ago

Some users won't log in again (☠️), - and this will be a bad look in any place where we'd like to show their avatar. In the user select e.g., or soon we'll add the user list dropdown under the '10 students learn this course' stat.

anandvenkat4 commented 4 years ago

Got it. In that case, are we presenting an option(in future) for the users to change their profile picture fro our platform?

lakesare commented 4 years ago

Absolutely, here is the issue for that functionality: https://github.com/lakesare/memcode/issues/22.