WIP: Make sure we get user's email from Github! #33

[anandvenkat4]

Fixed the email update.

[lakesare]

Looks good to me! A little nitpick, - it's hard to read, we could refactor it into:

const fetchProfile = fetch('https://api.github.com/user', ...);
const fetchEmail = fetch('https://api.github.com/user/emails', ...);

Promise.all([fetchProfile, fetchEmail])
  .then([profile, emails] => {
    const email = emails[0];
    profile.email = email;
    return profile;
  })

[anandvenkat4]

Looks good to me! A little nitpick, - it's hard to read, we could refactor it into:

const fetchProfile = fetch('https://api.github.com/user', ...);
const fetchEmail = fetch('https://api.github.com/user/emails', ...);

Promise.all([fetchProfile, fetchEmail])
  .then([profile, emails] => {
    const email = emails[0];
    profile.email = email;
    return profile;
  })

Should I go ahead and make the changes?

[lakesare]

Perfect, merging 💟