lakesare / memcode

Spaced-repetition: with real formatting.
http://memcode.com
MIT License
335 stars 72 forks source link

We shouldn't refresh notifications on every page + fix localStorage #59

Open lakesare opened 4 years ago

lakesare commented 4 years ago
  1. Notifications should be renewed without setting { status: 'request' } on subsequent api calls.

  2. There shouldn't be a residual '1 notification is unread' when we:

This happens because we don't update value in our localStorage whenever amount of unread notifications changes.

lakesare commented 4 years ago

Let's put <Notifications/> state into redux instead of keeping it in the component.