search

lakesare / memcode

Spaced-repetition: with real formatting.
http://memcode.com
MIT License
335 stars 72 forks source link

Gitpod docs update #63

Closed kgashok closed 4 years ago

kgashok commented 4 years ago

The progress bar works, sort of.

I tested it with 1, 2 and 3 cards.

It would be nice if the animation happened after the answer was revealed.

lakesare commented 4 years ago

It's probably better than what we have now, but this doesn't exactly fix #37 as you mentioned. I'll merge updated .md file, and see if 1 + this.props.statusOfSolving.index looks better than what we have now in action 👍

kgashok commented 4 years ago

It's probably better than what we have now, but this doesn't exactly fix #37 as you mentioned. I'll merge updated .md file, and see if 1 + this.props.statusOfSolving.index looks better than what we have now in action 👍

I took cue from https://github.com/lakesare/memcode/blob/3d526ffde553e46b4af87ec8c06339bbb2f3b811/frontend/pages/courses_id_review/components/ProblemBeingSolved/components/Subheader/index.js#L94

for arriving at the 1 + logic.

lakesare commented 4 years ago

I actually quite like the 1+ solution. I won't mark the issue 37 with #fixed just yet, but I will deploy it. Thanks, @kgashok!