lakesare / memcode

Spaced-repetition: with real formatting.
http://memcode.com
MIT License
330 stars 71 forks source link

Performance with a lot of Quill editors #97

Open lakesare opened 4 years ago

lakesare commented 4 years ago

Multiple users reported diminished performance when dealing with 100+ flashcards. It has been partially fixed by loading the flashcards in batches of 20 flashcards, - but this fix still staggers performance and even introduces editing issues reportedly. See https://github.com/quilljs/quill/issues/627, https://github.com/quilljs/quill/issues/2149, https://github.com/quilljs/quill/issues/1482.

Possible solutions:

Perfect solution:

nichwch commented 3 years ago

Have you considered using something like a quill html renderer to display the flashcard, and load React-Quill when the user wants to edit the contents?

lakesare commented 3 years ago

@nichwch, we actually do something of a kind already - we lazy load batches of flashcards (first all 100 flashcards are displayed as html, then 10 by 10 they get converted to Quill). The solution you propose would require the user to click the flashcard twice in order to edit it.


However I think we've dealt with this issue indirectly - since we started rendering the new flashcard on top users don't seem to notice that other flashcards haven't yet loaded. Do you still experience some lagging?

nichwch commented 3 years ago

apologies, i'm using quill in a personal project and mistook this for a Quill issue - i see now that this is for the memcode product. i'm not a user, i can't speak to whether your site lags

sorry for the confusion