search

lakinduakash / linux-wifi-hotspot

Feature-rich wifi hotspot creator for Linux which provides both GUI and command-line interface. It is also able to create a hotspot using the same wifi card which is connected to an AP already ( Similar to Windows 10).
BSD 2-Clause "Simplified" License
3.26k stars 301 forks source link

Use 'aa-complain' instead of 'complain' to remove dnsmasq restriction #314

Closed TiPEX360 closed 1 year ago

TiPEX360 commented 1 year ago

Using the default installation from the AUR, I ran into the following error when trying to create a hotspot:

dnsmasq: cannot read /tmp/create_ap.wlp18s0.conf.fgQTo8iD/dnsmasq.conf: Permission denied

This looks like it's related related to an old issue with create_ap discussed here, where @mehdisadeghi has found a solution, although it seems it hasn't been implemented.

Seems like complain is being used to remove restrictions on dmsmasq, although the command is supposed to be aa-complain. At least, this has been the case when testing on my system (Manjaro) as well as on Arch according to that thread.

From the OpenSUSE docs, it looks like aa-complain is the correct command on OpenSUSE distros as well, so I think it makes sense to make this change: https://doc.opensuse.org/documentation/leap/security/html/book-security/cha-apparmor-commandline.html

I imagine this requires a bit more testing though.

lakinduakash commented 1 year ago

Thanks for the contribution, This also needs to be compatible with complain command as well.

TiPEX360 commented 1 year ago

Thanks for the contribution, This also needs to be compatible with complain command as well.

Thanks for the response; I've made some changes to check for both. Do you happen to know in what context / which systems complain is used instead of aa-complain? I tried to find out more about it online but most references point me to aa-complain.

lakinduakash commented 1 year ago

Thanks. I think you missed the $. I fixed it.

lakinduakash commented 1 year ago

closes #269 #304 #218 #183

niksingh710 commented 1 year ago

@lakinduakash when will this be merged and released in the build?