search

lakiw / cripts

CRIPTs - Collaborative Research Into Password Threats
MIT License
2 stars 0 forks source link

"All" option not resetting title of list views #4

Open lakiw opened 8 years ago

lakiw commented 8 years ago

If you click on the "All" option of list views it still shows the previous selection in the title. For example, if you click on "New" when viewing events the title says "New Events", but when you click on "All" it still lists "New Events". Mostly a minor annoyance. This is an issue with CRITs as well.

lakiw commented 8 years ago

Commit https://github.com/lakiw/cripts/commit/4f8178605febbe82e75f0f4a89269dd75cdfe403 fixes this issue for the most part. Basically in the hander.py for a TLO you need to pass

{'refresh': 'yes','status': 'All'}

It's not a perfect fix since when you initially go to a listing it doesn't list anything, but when you click on "All" it lists "TLO - All" which could be confusing. I can't leave it blank though since otherwise it'll replace it with "TLO -" which also looks weird. Long story short this will probably require a lot more digging to fix to make it look perfect and it's mostly fixed so I'm closing this issue.

lakiw commented 8 years ago

Well it looks like it is using the status text when doing searches so the previous fix doesn't work.