Port to libadwaita 1.4 widgets

lakoliu / Furtherance

Track your time without being tracked

GNU General Public License v3.0

243 stars 24 forks source link

Port to libadwaita 1.4 widgets #129

Closed gabrbrand closed 4 months ago

gabrbrand commented 4 months ago

SwitchRow + SpinRow Requires runtime-version 45 (and above) (See https://github.com/flathub/com.lakoliu.Furtherance/issues/9)

TODO

[x] Remove unused PreferencesGroup references/ids
[x] Update access keys

gabrbrand commented 4 months ago

Do we need a reference to each preference group in src/ui/preferences_window.rs or can we remove them (including the id in src/gtk/preferences_window.ui)?

gabrbrand commented 4 months ago

I have updated the access keys of the preferences window following GNOME HIG. Furtherance currently doesn't have any access keys for the three navigation tabs. The letters 'T' and 'D' are already used on the pages. Any ideas?

Screenshot from 2024-02-12 10-38-30

lakoliu commented 4 months ago

Thanks for doing all this work Gabriel, this looks great! As to the first question, yes, all of the PreferencesGroup references and IDs can be removed except appearance_group. As for the access keys, for the first tab maybe we can change Inclusive Total Time to "I" and then use T for Tasks? As for the Data tab, I'm drawing a blank. Perhaps we should change "Days ago" to "Limit history shown" (I like the wording better anyway), and set that to H.

gabrbrand commented 4 months ago

"Limit history shown" would be kind of a duplication of the expander label. I've therefore used "Number of days" instead.
Capitalization (GNOME HIG)
I've removed the access key for dark theme, as most user won't see it anyway.

Screenshot from 2024-02-12 19-58-22

lakoliu commented 4 months ago

Awesome, looks good to me! Thanks again, I really appreciate the work you've put in.