search

lakoliu / Furtherance

Track your time without being tracked
GNU General Public License v3.0
258 stars 23 forks source link

Logo is off-centered in canvas #27

Closed pesader closed 2 years ago

pesader commented 2 years ago

First of all, the new logo looks amazing!

However, it does seem to be slightly off-centered. As you can hopefully see in the screenshot below, Furtherance looks oddly lower than other application logos:

image

It seems to easily fixable by centering the logo in the canvas. Thanks for developing Furtherance :rocket::timer_clock:

pesader commented 2 years ago
Since the fix was really quick I vertically aligned both hicolor icons in Inkscape. Before After
image image

I submitted a PR with this fix in case it looks good to you :)

lakoliu commented 2 years ago

Thanks for bringing this up, and for fixing it! I agree with you that the logo is oddly low, and I had actually fixed it myself already but decided not to upload it. The reason for that is the GNOME Guidelines require the bottom line of the app to be touching the bottom line of the icon template, which it was.

The issue, though, was that the task list was under the bottom line, making it seem lower, even though the bottom of the clock was on the same bottom line as the other app icons. I've now changed this, moving the task list in the icon to the bottom line. Hopefully that still meets the GNOME Guidelines and makes it look better. Centering the app pushes it just slightly higher than having the task list on the bottom line, which is why I changed it rather than merging your fix. I really appreciate you taking the time though, and I will still give you credit in the changes when I put out the next release!

I will leave this issue open until the next release because I'd like your feedback on how it looks then. Also, if anyone close to the GNOME team sees this, please let me know if this does not follow the guidelines.

pesader commented 2 years ago

Thanks a lot for taking the time to write this detailed feedback! This sort of friendly collaboration is what I love the most about free and open source software.

Also, I didn't know about that GNOME human interface guideline and am glad you brought it up! I plan to develop a GNOME app myself one day, so this was a valuable learning for me :)

lakoliu commented 2 years ago

The clock was moved up in v1.1.3, but after seeing it mixed in with the other GNOME apps, as well as a conversation I had with Tobias Bernard, who created the icon, I realized it looks out of place. The main element (the clock) should sit on the baseline to match other GNOME apps, even if the top then looks a bit low. Therefore it will be lowered again in the next release. I know it can look a bit out of place in the dock this way, but I think it's overall the best look for Furtherance. Thank you though for bringing this conversation to the table!