Open lakshyakanungo opened 1 year ago
@lakshyakanungo A few comments
reset
here? https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/Contacts/Pane/Form.jsx#L71-L75 https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/Notes/Pane/Form.jsx#L89-L93t
here: import { t } from "i18next";
https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/Contacts/Table/utils.jsx#L3format
prefix since we are formatting the date here and not "getting" anything. Also in the latter case, it does not make sense to name it geMonthAndDate
as the month is a part of the date. Please choose the naming wisely. https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/utils/index.js#L5-L7noop
shouldn't be declared here. It is being utilized by many other components. Please move them to the utils file of the necessary scope. https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/Notes/index.jsx#L15Overall I can clearly see a lack of self-review in your codebase. I haven't exhaustively pointed out all the errors. It is your responsibility to find similar errors in the codebase and correct them. Ensure that you go through these reviews before submitting the cine-searcher app.
cc: @yedhink
@lakshyakanungo Please go through this video without fail:
Deployed at : https://main-app.neetodeployapp.com/notes Can be logged in using: Username : oliver@example.com Password : welcome
@yedhink @navaneethsdk Please review
I didn't know merging the pull request would delete the review app so again mentioning you after deploying in staging.