Deploy application on neeto deploy

[lakshyakanungo]

Deployed at : https://main-app.neetodeployapp.com/notes Can be logged in using: Username : oliver@example.com Password : welcome

@yedhink @navaneethsdk Please review

I didn't know merging the pull request would delete the review app so again mentioning you after deploying in staging.

[navaneethsdk]

@lakshyakanungo A few comments

• [x] Why is type not reset here? https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/Contacts/Pane/Form.jsx#L71-L75 https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/Notes/Pane/Form.jsx#L89-L93
• [x] This is not the right way to name event handlers. You ought to know the right way to name it by now. https://courses.bigbinaryacademy.com/learn-react/event-handling/event-handlers/ https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/Contacts/Pane/Create.jsx#L13
• [x] Let's directly import t here: import { t } from "i18next"; https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/Contacts/Table/utils.jsx#L3
• [x] Let's use the format prefix since we are formatting the date here and not "getting" anything. Also in the latter case, it does not make sense to name it geMonthAndDate as the month is a part of the date. Please choose the naming wisely. https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/utils/index.js#L5-L7
• [x] This can be moved to a separate component or a utils function. https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/Contacts/Table/utils.jsx#L59-L79
• [x] Do not include futile comments in the codebase. Please remove them since you are not using them. https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/Contacts/index.jsx#L33-L36
• [ ] Could you tell me how this works? https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/Contacts/index.jsx#L37
• [x] Let's use camelCase keys for front-end translations. I am seeing mixed-type cases here which is clearly a red flag at this point. https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/Notes/Card.jsx#L43
• [x] Let's destructure these compound components. https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/Notes/Card.jsx#L59-L60
• [x] Could you tell me where you use this Table component? https://github.com/lakshyakanungo/neeto-ui-challenge/blob/main/app/javascript/src/components/Dashboard/Notes/Table.jsx
• [x] Do not use abbreviations while naming entities. https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/Notes/index.jsx#L57 https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/Notes/index.jsx#L64
• [x] noop shouldn't be declared here. It is being utilized by many other components. Please move them to the utils file of the necessary scope. https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/Notes/index.jsx#L15
• [x] Localisation is not applied here. Please look for other instances and correct them. https://github.com/lakshyakanungo/neeto-ui-challenge/blob/4ae663439e6a358d100644d6ed33d24de1b2d920/app/javascript/src/components/Dashboard/Notes/Pane/Edit.jsx#L14

Overall I can clearly see a lack of self-review in your codebase. I haven't exhaustively pointed out all the errors. It is your responsibility to find similar errors in the codebase and correct them. Ensure that you go through these reviews before submitting the cine-searcher app.

cc: @yedhink

[navaneethsdk]

@lakshyakanungo Please go through this video without fail:

• https://vimeo.com/manage/videos/868346042/fcd1acd7c5
• https://vimeo.com/manage/videos/868348625/8d5b3255bf