Closed laur89 closed 3 years ago
Thanks for your PR! I appreciate your effort but you are changing a lot all at once.
What is the reason for changing all variables to upper case in the "minor bash cleanup"?
Preserving the query is a great feature but please don't change the structure (adding the loop) at the same time - it makes it hard to follow what you are doing.
Could you remove the cleanup and the loop from this PR for now?
PR is rather large, but features are separated by commit.
What is the reason for changing all variables to upper case
It's a common convention to denote global variables.
Preserving the query is a great feature but please don't change the structure (adding the loop) at the same time - it makes it hard to follow what you are doing.
Majority of the implementation remains same, it's just the indentation-shift that makes it seem like a major change.
I'll try and break changes up further.
Let's continue on https://github.com/laktak/extrakto/pull/49