search

laktak / extrakto

extrakto for tmux - quickly select, copy/insert/complete text without a mouse
MIT License
878 stars 45 forks source link

preserve fzf query across ctrl+{f,g} cycles #49

Closed laur89 closed 3 years ago

laur89 commented 3 years ago

After (and if) this gets merged, I propose following PRs (in that order):

https://github.com/laur89/extrakto/tree/feature/remove-recursion https://github.com/laur89/extrakto/tree/feature/sh-cleanup https://github.com/laur89/extrakto/tree/feature/colorize-fzf-hdr

laktak commented 3 years ago

Thank you, this works great!

You are welcome to submit your other PRs as well.

Only for the sh-cleanup please keep the lowercase variable names (https://unix.stackexchange.com/a/42849/46158 suggest to use lower case to avoid conflicts with env. variables).

laur89 commented 3 years ago

Would you consider some other format for global vars? Maybe camel-case?

laktak commented 3 years ago

We could add an opt_ prefix for the options, so e.g. opt_grab_area instead of grab_area.