search

laktak / extrakto

extrakto for tmux - quickly select, copy/insert/complete text without a mouse
MIT License
878 stars 45 forks source link

Fix an issue where the FZF pane/popup will stay open after opening the selected item #80

Closed marwan-tanager closed 2 years ago

marwan-tanager commented 3 years ago

I perceive this as a bug because it's expected that opening the item will result in closing the popup/pane just like when yanking.

laktak commented 2 years ago

Thank you! I think that bug was introduced when we moved the code to the open function.

m040601 commented 2 years ago

it's expected that opening the item will result in closing the popup/pane

I had been using extrakto for months, with this not working. Never thought it was a bug, so never reported it. I thoughtt instead it was something wrongly configured in my url openers, $BROWSER variable etc.

After this commit it's now working flawlessy.

Thanks to everyone involved. Nice to see many eyes watching over extrakto. and nice to see that it is being taken good care of.

Best tmux helper, EVAhhhhr :-)

laktak commented 2 years ago

Thanks for your note! :)

Also because we don't have/want analytics it's still nice to know what features are being used.