Windows installation fails due to pty.js dependency

[bkize]

The punch dependency on sftp introduces another dependency on pty.js. When a node-gyp rebuild happens during node install punch, the following error occurs:

 ..\src\pty.cc(20): fatal error C1083: Cannot open include file: 'unistd.h': No such file or directory [C:\dev\punch\node_modules\punch\node_modules\sftp\node_modules\pty.js\build\pty.vcxproj]

The lack of unistd.h on Windows is documented here.

This closed pty.js issue includes a statement by the author of pty.js regarding support for Windows, which can be summarized as "not possible".

Here are details regarding my configuration:

• Windows 7 64-bit
• Node.js 0.8.14 (x64)
• npm 1.1.65
• punch 0.4.18
• pty.js 0.1.2

I hope I'm overlooking an obvious solution or workaround as I was looking forward to trying Punch.

Brian

[laktek]

Unfortunately, I haven't got access to a Windows 7 machine to see the exact issue. But if dependencies for SFTP is causing the issue, we can consider to move it from the core and make it a plugin.

[laktek]

Try installing the latest version of Punch - 0.5.0. I have moved SFTP publishing has been moved to its own plugin. This will also remove the problematic dependency on pty.js.

[bkize]

Yes, the new Punch version fixed the issue. Punch installed without an error on this Windows 7 system. Thanks for the prompt response and update.

Brian