search

laktek / really-simple-color-picker

Simple Color Picker written in jQuery.
http://laktek.com/2008/10/27/really-simple-color-picker-in-jquery
MIT License
179 stars 65 forks source link

Support Transparency, additional options, and standard jQuery plugin syntax. #1

Closed dcompute closed 12 years ago

dcompute commented 12 years ago

Hey there Lakshan. I found your jQuery Color Picker plugin very useful. We needed something similar to what you had created for our site, but with a couple enhancements. I updated your library to use a more conventional jQuery plugin format, as well as gave it the ability to support Transparency as well as a few additional options. You can see the final result in use on the Readability website, under the Free Tools page. Thought others may find the changes useful as well. Thanks!

laktek commented 12 years ago

Hi Daniel,

Many thanks for your updates to the Really Simple Color Picker. Glad to see it's used in Readability as well (I love and use it everyday!)

I will merge your Pull Request soon.

Best Regards, Lakshan

On Tue, Feb 14, 2012 at 12:53 AM, Daniel Lacy < reply@reply.github.com

wrote:

Hey there Lakshan. I found your jQuery Color Picker plugin very useful. We needed something similar to what you had created for our site, but with a couple enhancements. I updated your library to use a more conventional jQuery plugin format, as well as gave it the ability to support Transparency as well as a few additional options. You can see the final result in use on the Readability website, under the Free Tools page. Thought others may find the changes useful as well. Thanks!

You can merge this Pull Request by running:

git pull https://github.com/dcompute/really-simple-color-picker master

Or you can view, comment on it, or merge it online at:

https://github.com/laktek/really-simple-color-picker/pull/1

-- Commit Summary --

  • Major rewrite of code.
  • Little organization, privitizing some variables.
  • Privatizing core functions that wouldn't be useful externally. Trying to improve capabilities of binding the picker to more than one element per-page.
  • Adding a little documentation to defaults. Adding back in addColors option (to be improved upon soon).
  • Little better handling of multiple instances on a single page. Fixing an event bubbling issue.
  • Fixing default color selection. Discovering that outerclick is totally screwed.
  • Event bubbling fixed. Should be good for testing now.
  • Fix for default color in palette input.
  • Updating Copyright to properly reflect MIT license. Adding minified version of library.

-- File Changes --

M jquery.colorPicker.js (451) A jquery.colorPicker.min.js (26)

-- Patch Links --

https://github.com/laktek/really-simple-color-picker/pull/1.patch https://github.com/laktek/really-simple-color-picker/pull/1.diff

Reply to this email directly or view it on GitHub: https://github.com/laktek/really-simple-color-picker/pull/1

dcompute commented 12 years ago

Glad you find the changes to your Color Picker and Readability useful. Hopefully the code quality is alright. We've been using it in production for about seven months before I realized that I never submitted my changes back. If something catches your eye, feel free to make a note and I'll clean it up. Thanks for the great plugin!