search

lalalilo / aws-spa

A no-brainer script to deploy a single page app on AWS
42 stars 3 forks source link

Separate distincts workflows #61

Closed GregdTd closed 3 months ago

GregdTd commented 3 months ago

Separate two distincts workflows depending on shouldBlockBucketPublicAccess variable. This ease reading and simplify debugging. Ensure any existing OAC is deleted.

BREAKING CHANGE: The following IAM rights are now required:

- cloudfront:ListOriginAccessControls,
- cloudfront:UpdateDistribution,
- cloudfront:GetOriginAccessControl

Additional IAM right are also necessary if using shouldBlockBucketPublicAccess:

- cloudfront:CreateOriginAccessControl,
- cloudfront:DeleteOriginAccessControl
codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.23%. Comparing base (f378c76) to head (c6422a2).

Files Patch % Lines
src/cloudfront/origin-access.ts 16.66% 5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #61 +/- ## ========================================== - Coverage 83.18% 82.23% -0.95% ========================================== Files 13 13 Lines 452 456 +4 Branches 85 85 ========================================== - Hits 376 375 -1 - Misses 76 81 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LaliloCI commented 3 months ago

:tada: This PR is included in version 4.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: