File storage - Githubissues

lars18th commented 5 months ago

Hi @lalbornoz ,

This is a great project. I'm comming from KiTTY, and this PuTTY fork seems very good. Congratulations!

However, I've missing some useful functionalities from KiTTY. But, I don't want to request you to implement all of them. This is a different fork, and time to time it's good to re-think from zero. 😉

Regarding the FILE STORAGE functionality, that IMHO is the most must-have functionality missing in PuTTY, I feel you can improve PuTTie on these points:

Describe in the README the location of the configuration directory. After reading the source code I discovered that is %APPDATA%\PuTTie\*. I feel this a very relevant information that the user needs to know. Don't you think so?
Provide a command-line parameter to set the location of this directory. One reason to use file storate is to sync config between different machines. And when you're using this, it's common to have this is a directory like C:\PORTABLE\. Therefore the current implementation will improve with these changes: putty.exe --file C:\PORTABLE\PiTTie\: use the listed directory to store the configuration. And putty.exe --file .: use the directory where the binary is... and not the local directory (this is a special case, and if you don't agree, then you could use --file-root). I hope you agree with this.
What's the command-line parameter to list all parameters? The values /?, -h and --help doesn't work. Please, help.

Regards.

lalbornoz commented 5 months ago

All great ideas, will implement this soon. Thanks!

lars18th commented 5 months ago

Reading in more detail the README, I recommend to follow this syntax for the file parameter:

--file: like now, uses %APPDATA%\PuTTie\.
--file=;C:\my-directory: uses this explicit full-path directory.
--file=;.\my-directory: uses this explicit relative-path directory from the "current directory".
--file=registry: file storage initialized from the Registry.
--file=;~: uses the path from where the binary is stored.
--file=registry;~.\another-subdir: combination of the previous parameters, in this case regsitry+relative-path+root-binary.

I suggest this syntax to follow the common --parameter=value model that you're using. And separating the multiple combinations while keeping the current format (for --file and --file=registry).

What you think?

jslegers73 commented 5 months ago

Hi,

I have tried the --file=;~ option but I get an error that it is an unknown parameter. I want to use Puttie like I did with Kitty using the local path where putty.exe is located.

This would be great.

lars18th commented 5 months ago

Hi @lalbornoz ,

Nice work with the latest updates! However, regarding the command line help, I have a small suggestion: Please add a simple way to distinguish between "generic" (from PuTTY) and "new" (from PuTTie) parameters. Example:

    printf("Options:\n");
    printf("  -?\n");
[...]
    printf("New options:\n");
    printf("  --file\n");
    printf("  --ephemeral\n");
[...]

Do you agree?

lalbornoz commented 5 months ago

Agree

jslegers73 commented 5 months ago

Nice work. Can I test the change already (Windows machine) ?

lalbornoz commented 4 months ago

Implemented in 54773f7e9332dea43af4b684fbe13e778ca455e4.

jslegers73 commented 4 months ago

Thank you for your response. However when I try putty -h nothing happens.

On Tue, May 7, 2024 at 4:33 PM Lucía Andrea Illanes Albornoz < @.***> wrote:

Implemented in 54773f7 https://github.com/lalbornoz/PuTTie/commit/54773f7e9332dea43af4b684fbe13e778ca455e4 .

— Reply to this email directly, view it on GitHub https://github.com/lalbornoz/PuTTie/issues/13#issuecomment-2098553391, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPMYQK3KSBPIEUAIXOUWADZBDQ33AVCNFSM6AAAAABHHQ6NCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJYGU2TGMZZGE . You are receiving this because you commented.Message ID: @.***>

-- Met vriendelijke groet / With kind regards,

J. Slegers

lars18th commented 4 months ago

Implemented in 54773f7.

Nice work! I'll test it soon. Thank you.

lars18th commented 4 months ago

However when I try putty -h nothing happens.

Me too! When I call it with /? a window error appears. When I use -h nothing happens. Moreover, when using --file=;~ it dosn't work too.

Any idea?

lalbornoz commented 4 months ago

Thank you for your response. However when I try putty -h nothing happens.

As in nothing is printed to the console/stdout?

lalbornoz commented 4 months ago

However when I try putty -h nothing happens.

Me too! When I call it with /? a window error appears. When I use -h nothing happens. Moreover, when using --file=;~ it dosn't work too.

It's presently -h, --help, or -?. What do you mean by doesn't work? Does saving a session when --file=;~ was specified save it to the correct location?

lars18th commented 4 months ago

However when I try putty -h nothing happens.

Me too! When I call it with /? a window error appears. When I use -h nothing happens. Moreover, when using --file=;~ it dosn't work too.

It's presently -h, --help, or -?. What do you mean by doesn't work? Does saving a session when --file=;~ was specified save it to the correct location?

If I execute putty.exe --help nothing happens. The App is not opened and nothing is printed in the console. Similar with other parameters. Including putty.exe --file=;~. This is true in Windows 11 with both: CMD and Windows Terminal; and with the last build: PuTTie Release build (Git commit 54773f7e on branch master)

lalbornoz commented 4 months ago

Reproduced both on Windows 10 (I do my testing on wine & Linux) - thanks. Both should be fixed in the upcoming releases.

lalbornoz commented 4 months ago

https://github.com/lalbornoz/PuTTie/releases/tag/PuTTie-file-Release-31a335e7 https://github.com/lalbornoz/PuTTie/releases/tag/PuTTie-registry-Release-31a335e7

jslegers73 commented 4 months ago

Hello,

I can confirm that the -h option works now thanks. How can I store the session info directory in the same directory where Putty is located?

John

On Tue, May 7, 2024 at 8:14 PM Lucía Andrea Illanes Albornoz < @.***> wrote:

https://github.com/lalbornoz/PuTTie/releases/tag/PuTTie-file-Release-31a335e7

https://github.com/lalbornoz/PuTTie/releases/tag/PuTTie-registry-Release-31a335e7

— Reply to this email directly, view it on GitHub https://github.com/lalbornoz/PuTTie/issues/13#issuecomment-2099030620, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPMYQN2ROLXKAZUKSRGOLLZBEKYHAVCNFSM6AAAAABHHQ6NCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJZGAZTANRSGA . You are receiving this because you commented.Message ID: @.***>

-- Met vriendelijke groet / With kind regards,

J. Slegers

lalbornoz commented 4 months ago

--file=;~, as was discussed in this issue. Closing this now.

lars18th commented 4 months ago

https://github.com/lalbornoz/PuTTie/releases/tag/PuTTie-file-Release-31a335e7 https://github.com/lalbornoz/PuTTie/releases/tag/PuTTie-registry-Release-31a335e7

Hi @lalbornoz ,

I confirm that all related bugs are now fixed. Thank you.

However, it's quite annoying that the help is printed in a new window. I don't expect this! 😆

lalbornoz commented 4 months ago

Thanks! Agree, but you can blame Windows for that.

jslegers73 commented 4 months ago

Thanks that was it for the local directory.

On Wed, May 8, 2024 at 9:22 AM Lucía Andrea Illanes Albornoz < @.***> wrote:

Thanks! Agree, but you can blame Windows for that.

— Reply to this email directly, view it on GitHub https://github.com/lalbornoz/PuTTie/issues/13#issuecomment-2099915034, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPMYQJAUUOBAOHNNVAP5DLZBHHCVAVCNFSM6AAAAABHHQ6NCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJZHEYTKMBTGQ . You are receiving this because you commented.Message ID: @.***>

-- Met vriendelijke groet / With kind regards,

J. Slegers

lalbornoz / PuTTie

File storage #13