lalbornoz / PuTTie

PuTTie loves you 💚
Other
52 stars 0 forks source link

KiTTY duplicate shortcut #31

Open larena1 opened 4 months ago

larena1 commented 4 months ago

Could you add the duplicate shortcut from KiTTY?

It's CTRL ALT T by default and a lot quicker to use from a terminal session than the other shortcut involving the mouse.

https://github.com/cyd01/KiTTY/blob/75fa2abcd220c17249ff7252f8d5224137001f2d/kitty.c#L4994

lars18th commented 4 months ago

Hi @larena1 ,

I would like to comment on this politely because I think all comments are positive. So I'm not the one who should limit them.

However, I think is not positive if all functionalities from KiTTY are requested for PuTTie. I'm aware that a lot of users are moving from KiTTY to PuTTie (me too). But, I feel it could be a wrong idea to request a lot of different functionalities without an initial discussion about them. Therefore, my suggestion is to implement only "new" functionalities after rethinking on them. With this approach it could be more easy to maintain this very good designed fork.

That said, I've discussed support for "user shortcuts" in KiTTie before. My opinion at this point is to wait until we discuss the best option to implement them.

I apologise if that sounds rude. It's clearly not my intention. I just want to be constructive. And I prefer @lalbornoz to comment on her position. Regads.

lalbornoz commented 4 months ago

I'm not opposed to implementing KiTTY/... features as long as the implementation & maintenance cost footprint is reasonable. What I think I'll end up doing is merging all those sorta features plus this one into Frippery -> Shortcuts or Mappings or some such.

larena1 commented 4 months ago

I personally don't need any other shortcuts so for me if would be enough if I could duplicate the session using CTRL ALT T as in KiTTY basically as an alternative to the existing shortcut involving the mouse.

@lars18th thanks for your feedback and no offense but I unfortunately feel like it did not add anything of value to this issue.

lars18th commented 4 months ago

Hi,

Since everyone seems to be open to commenting on this request... or on "user shortcuts", I want to share my opinion. 😉

In KiTTY I've discovered that some shortcuts can interfere with the terminal. We need to not forget that this is a TERMINAL. Therefore, the remote application is reading keystrokes, and some combination could generate conflicts. That's the reason why I'm disabling by default all shortcuts in KiTTY. And only enabling some that I really need.

So, to minimise conflicts, I suggest establishing a general design guideline. For example, we could follow any of these:

Could you please share your thoughts/experiences/comments ? 😸

lalbornoz commented 4 months ago

Meow meow! Mrrrr, prrrt? Mew mew, hiss! Purr purr, nyaa! Prrrt prrrt, mrrp! Mrrrow, mrrrow! Nyaa, mrow! Mlem! Paws tap, maw!

larena1 commented 2 months ago

@lalbornoz have you already given up maintaining your fork?