search

lalitmetkar / vim

Automatically exported from code.google.com/p/vim
0 stars 0 forks source link

[PATCH] Make --enable-pythoninterp fail if Python cannot be found #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
If --enable-pythoninterp is specified on the command line and Python is not 
found in the path, then Vim will build anyway without the Python interpreter. 
This patch to configure.in makes sure that ./configure fails without continuing.

I plan to implement more checks like that in the branch 
'autoconf-error-on-unattainable-features' here:

http://code.google.com/r/shlomif-changes/

Regards,

-- Shlomi Fish

Original issue reported on code.google.com by shlomifi...@gmail.com on 18 Jun 2011 at 1:41

Attachments:

GoogleCodeExporter commented 9 years ago 
There are many people who add lots of command line arguments, and expect 
configure to use the ones that work.  This patch to bail out if something if 
failing breaks that.

How about adding another argument --fail-if-missing?

Doesn't configure have a nicer way to abort than 'exit 1'?

Original comment by brammool...@gmail.com on 18 Jun 2011 at 6:23

GoogleCodeExporter commented 9 years ago 
Bram: yes, I've been thinking of something like that myself (a 
"--fail-if-missing" option). However, I don't know how to add it to 
"configure.in" without putting it inside an --enable option. Can you shed some 
light about it?

Original comment by shlomifi...@gmail.com on 18 Jun 2011 at 8:43

GoogleCodeExporter commented 9 years ago 
Bram: so what do you think?

Original comment by shlomifi...@gmail.com on 21 Jun 2011 at 7:24

GoogleCodeExporter commented 9 years ago 
Hi Bram!

Can you please voice your opinion about that? It's been over two weeks since my 
last message. I think the best policy would be to have both a command line 
option and an environment variable (say "FAIL_IF_MISSING") that can be set. But 
I need your input to proceed further.

Regards,

-- Shlomi Fish

Original comment by shlomifi...@gmail.com on 8 Jul 2011 at 12:09

GoogleCodeExporter commented 9 years ago 
OK, now http://code.google.com/r/shlomif-changes/ contains a 
--enable-fail-if-missing flag that also controls failure on the rest of the 
interpreters. (Tested on Linux).

The patch is attached, but you should try Mercurial first.

Regards,

-- Shlomi Fish

Original comment by shlomifi...@gmail.com on 11 Jul 2011 at 3:57

Attachments:

GoogleCodeExporter commented 9 years ago 
Patch included

Original comment by brammool...@gmail.com on 14 Dec 2011 at 7:56