search

laloch / kwin-effect-osdclock

KWin effect that displays clock at the corner of the screen
GNU General Public License v2.0
11 stars 2 forks source link

Broken after update to plasma 5.21 #3

Open ben2talk opened 3 years ago

ben2talk commented 3 years ago

Sadly fails at 90%

[ 90%] Building CXX object src/CMakeFiles/kwin_osdclock.dir/osdclockconfig.cpp.o
/home/ben/.cache/paru/clone/kwin-effect-osdclock-git/src/kwin-effect-osdclock/src/osdclock.cpp: In member function ‘virtual void OsdClockEffect::prePaintScreen(KWin::ScreenPrePaintData&, int)’:
/home/ben/.cache/paru/clone/kwin-effect-osdclock-git/src/kwin-effect-osdclock/src/osdclock.cpp:121:35: error: cannot convert ‘int’ to ‘std::chrono::milliseconds’ {aka ‘std::chrono::duration<long int, std::ratio<1, 1000> >’}
121 |     effects->prePaintScreen(data, time);
|                                   ^~~~
|                                   |
|                                   int
In file included from /home/ben/.cache/paru/clone/kwin-effect-osdclock-git/src/kwin-effect-osdclock/src/osdclock.h:28,
from /home/ben/.cache/paru/clone/kwin-effect-osdclock-git/src/kwin-effect-osdclock/src/osdclock.cpp:22:
/usr/include/kwineffects.h:835:85: note:   initializing argument 2 of ‘virtual void KWin::EffectsHandler::prePaintScreen(KWin::ScreenPrePaintData&, std::chrono::milliseconds)’
835 |     virtual void prePaintScreen(ScreenPrePaintData& data, std::chrono::milliseconds presentTime) = 0;
|                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
make[2]: *** [src/CMakeFiles/kwin_osdclock.dir/build.make:117: src/CMakeFiles/kwin_osdclock.dir/osdclock.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:265: src/CMakeFiles/kwin_osdclock.dir/all] Error 2
make: *** [Makefile:160: all] Error 2
==> ERROR: A failure occurred in build().
Aborting...
:: Packages failed to build: kwin-effect-osdclock-git-20190925.e1479a0-1
kalmarek commented 3 years ago

see #2 , but that's a buggy workaround ;) I don't know enough of kwin C++ to fix it properly

kalmarek commented 3 years ago

@ben2talk after spending 5 minutes more with the codebase the modified (trivial) patch in #2 seems to be the proper fix.

@laloch could you have a look?