search

laloch / xontrib-fzf-widgets

Set of fzf widgets for xonsh
GNU General Public License v3.0
33 stars 18 forks source link

Cannot bind key to fzf's history search #23

Open halloleo opened 2 years ago

halloleo commented 2 years ago

When I set 

$fzf_history_binding = "c-r"

and I type Ctrl-R still the normal xonsh backward search comes up.

Is this a compatebilty issue? Here all the steps I have done:

  1. I have installed fzf. It is now on my path: Typing fzf opens the fzf selector.
  2. I install the xontrib-fzf-widgets extension via xpip install xontrib-fzf-widgets.
  3. I load the extension via xontrib load xontrib-fzf-widgets.
  4. I issue in my xonsh shell $fzf_history_binding = "c-r".
  5. I type Ctrl-r.

And here the versions involved:

module version
xonsh 0.11.0
xontrib-fzf-widgets 0.0.4
fzf 0.29.0 (brew)
halloleo commented 2 years ago

Just found out what's the problem: I have to set $fzf_history_binding = "c-r" first and then load the xontrib!!!

Is this something which can be fixed? If not I'm happy to update the README to make users aware of the requested order.

laloch commented 2 years ago

Hi @halloleo, sorry for the delay. I will probably abandon and archive (or just abandon) this project. I'm not happy with the direction the OSS community has decided to take and I chose not to participate and contribute anymore.

halloleo commented 2 years ago

Thanks for the info, @laloch! Fair enough if you want to abandon the project.