laluka / bypass-url-parser

bypass-url-parser

https://linktr.ee/TheLaluka

GNU Affero General Public License v3.0

1.03k stars 108 forks source link

a small bug on mac #1

Closed alex123-2star closed 2 years ago

alex123-2star commented 2 years ago

I found a small bug on mac code ～～～

your code on mac

echo -e "\e[34m----------------------\e[0m"

my code on mac

echo "\033[30m black color \033[0m"

～～～

run

Your color code is not implemented and printed directly on the mac Thank you for your software, thank you for your efforts

laluka commented 2 years ago

Hi there, can you please submit a fix (patch or PR) that works on you side ? As I don't have a mac, I won't be able to spend time testing this, so if your patch works on my side, I'll merge it right away :) Cheers, Laluka

nuoxoxo commented 2 years ago

This is not a bug in itself. On MacOS, just use printf to properly display color when you make. On Linux, it is echo that works.

laluka commented 2 years ago

Hey guys, I don't own a mac, would you mind writing a PR for these changes ? Is they work on linux as well I'll merge them! 💟

Also, I might write a dockerfile for this so you can still benefit of it to the full :)

laluka commented 2 years ago

Well, just remembered there's no echo anymore, so it's "solved" haha

laluka commented 2 years ago

Moved from bash to python :)