laluka / bypass-url-parser

bypass-url-parser
https://linktr.ee/TheLaluka
GNU Affero General Public License v3.0
1.02k stars 108 forks source link

Source code refactoring and new features added #3

Closed jtof-fap closed 2 years ago

jtof-fap commented 2 years ago

Source code refactoring into a single block with the aim of providing a more solid base to add new features and bypass methods (to come).

Improved code and new features added:

Improved argument parsing:

Improved tool's output and results saving:

More PR to come ;-)

laluka commented 2 years ago

Heya! PR received, testing will be done within a few days. We spend quite some time chatting but I want this information to be public anyway: The work done here is HUGE, this SHALL be merged! :heart:

laluka commented 2 years ago

Ok, so this PR doesn't seem to introduce any regression, and adds tons of cool features! BUT we have a few things left to do before we merge it:

Fix the escaping so we don't introduce an argument rce

This would be really bad for folks with automation, and can also break some urls

python bypass-url-parser.py -u "http://127.0.0.1/foo/bar';`touch /tmp/rce`" -d
# Results in /tmp/rce being created

Update the readme with the new usages

Small log tweak

Display one line every 100 tests done to let the use know the tool is still running

Awesome work overall, looking forward to build from this one! :heart: :rose:

laluka commented 2 years ago

Don't mind my sample rce payload, it is missleading and erroneous, I'm still pretty sure this is vuln but this rce isn't introduced by the tool, I was definitely too tired.. :)

jtof-fap commented 2 years ago

Hi!

It's done! I pushed three extra commits to this pull request:

Enjoy ;-)