lalvim / PartialLeastSquaresRegressor.jl

Implementation of a Partial Least Squares Regressor
MIT License
40 stars 8 forks source link

kpls.jl trainer contains unused (but populated) matrix #21

Open donkeykonkey opened 3 years ago

donkeykonkey commented 3 years ago

A N x n_factors matrix, P, is allocated on line 59 in kpls.jl and then populated on line 103 but is otherwise unused. Not sure if julia optimizes it away, but if not it can be a pretty sizeable allocation that should be removed.