search

lalvim / PartialLeastSquaresRegressor.jl

Implementation of a Partial Least Squares Regressor
MIT License
40 stars 8 forks source link

CompatHelper: bump compat for "MLJModelInterface" to "0.4" #22

Closed github-actions[bot] closed 3 years ago

github-actions[bot] commented 3 years ago

This pull request changes the compat entry for the MLJModelInterface package from 0.3 to 0.3, 0.4.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

ablaom commented 3 years ago

The error is essentially due to an ancient version of MLJ kicking in for testing. MLJBase is updated for MLJModelInterface 0.4 but MLJ is not. You can expect a new MLJ patch within a week or two.

In any case, I suggest the new compat for MLJModelInterface be extended instead of bumped, as in "MLJModelInterface ="0.3,0.4".

ablaom commented 3 years ago

Okay, a quick look suggests you don't need MLJ for testing. Everywhere you have MLJ, you can substitute MLJBase, no?

ablaom commented 3 years ago

Suggest this is closed in favour of #23