search

lalvim / PartialLeastSquaresRegressor.jl

Implementation of a Partial Least Squares Regressor
MIT License
40 stars 8 forks source link

CompatHelper: bump compat for "MLJModelInterface" to "1.0" #24

Closed github-actions[bot] closed 3 years ago

github-actions[bot] commented 3 years ago

This pull request changes the compat entry for the MLJModelInterface package from 0.3,0.4 to 0.3,0.4, 1.0.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

ablaom commented 3 years ago

I see that an ancient version of MLJBase is kicking in here for testing, and hence the fail.

ablaom commented 3 years ago

I see that travis is not aware of julia 1.6 and is doing 1.5.4 test.

Using my local 1.5.1 I am unable to reproduce the fail. Also unable to reproduce using julia 1.6.

Anyone else able to reproduce this fail?

ablaom commented 3 years ago

As an aside, I wonder if the developers would consider switching to a github action for CI. If you are using the free version of travis testing, you should be aware there is now a quota. Can provide a PR if necessary.

ablaom commented 3 years ago

Having a very hard time reproducing this fail locally. The same package versions get loaded before testing locally as in the CI run, but on testing travis is putting old version of MLJBase instead of the most recent.

Going to try a new PR.

ablaom commented 3 years ago

@filipebraida Suggest you close this in favour of #25 which passes tests.

filipebraida commented 3 years ago

Thanks @ablaom

filipebraida commented 3 years ago

As an aside, I wonder if the developers would consider switching to a github action for CI. If you are using the free version of travis testing, you should be aware there is now a quota. Can provide a PR if necessary.

Yes, I will ask to @lalvim to do this. I will do this on my recsys packages on next vacation (may :D).