search

lamabiker / atom-ember-cli-helper

Ember CLI integration for the Atom editor
https://atom.io/packages/ember-cli-helper
MIT License
26 stars 13 forks source link

Settings option for the new "offer to generate file" feature #43

Closed caseywatts closed 6 years ago

caseywatts commented 7 years ago

This new feature sounds useful, but based on how I've been using the file-switching tool I'd like to turn it off: https://github.com/lamabiker/atom-ember-cli-helper/commit/23c181a8091a13d97144b6dfbb540cb367b49323

It looks like adding options to atom plugins is pretty straightforward, it would probably be easy to do something like this? https://github.com/lamabiker/atom-ember-cli-helper/pull/35/files I would have it default to its previous behavior.

(sidenote - I found a minor typo: https://github.com/lamabiker/atom-ember-cli-helper/commit/23c181a8091a13d97144b6dfbb540cb367b49323#diff-742193ccdd99b6a6a737d75141713b24R275 )

lamabiker commented 6 years ago

@caseywatts, the latest release (v0.17.0) should now have that option. Thanks for spotting the typo!

caseywatts commented 6 years ago

awesome, thanks!! :)