lamalab-org / matextract-book

http://matextract.pub/
MIT License
24 stars 1 forks source link

docs: recommend to do cloning first #121

Closed kjappelbaum closed 3 months ago

kjappelbaum commented 3 months ago
kjappelbaum commented 3 months ago

also seems to now install on Windows https://github.com/lamalab-org/matextract-book/actions/runs/10194735286/job/28201938287

one limitation of our tests, of course, is that we do not know if the code runs ...

MrtinoRG commented 3 months ago

So, to test this, the chunking notebook (I think it is the only one that uses ChromaDB) should be run, right?

kjappelbaum commented 3 months ago

So, to test this, the chunking notebook (I think it is the only one that uses ChromaDB) should be run, right?

This might be a good check to see if the current state works, but we can probably not easily run it in GitHub actions as it is too expensive/slow

MrtinoRG commented 3 months ago

So, to test this, the chunking notebook (I think it is the only one that uses ChromaDB) should be run, right?

This might be a good check to see if the current state works, but we can probably not easily run it in GitHub actions as it is too expensive/slow

But we can run it locally to check the current state of the dependencies

kjappelbaum commented 3 months ago

Nice, thanks for testing!