search

lamarios / clipious

Invidious client for android
GNU Affero General Public License v3.0
873 stars 30 forks source link

Support Unified Push #475

Closed seang96 closed 7 months ago

seang96 commented 7 months ago

Is your feature request related to a problem? Please describe. Unified Push is a protocol to send the push notification through one background process across supported applications which reduces background connections and improves battery life.

Describe the solution you'd like Add support for unified push. Documentation is accessible here https://unifiedpush.org/

Describe alternatives you've considered No other options are FOSS or require the background service that is currently implemented.

Additional context There are open source projects using this already such as matrix clients that may be good references for how it works.

lamarios commented 7 months ago

The app doesn't have push notifications. I'm not sue in what way this will help.

seang96 commented 7 months ago

I see notifications as a beta option in 1.18.0's settings.

Edit: haven't looked into any of this, perhaps it's more accurate that the implementation currently doesn't hook to a likely unavailable invidious API for them to be push notifications so it's not applicable until the backend supports this.

lamarios commented 7 months ago

Correct. All is done locally so it's not really a push notification. A "task" handled by android work manager is spawned at regular interval to check if there are new videos and will trigger a notification if it is the case.

I'll close this ticket.