bump Go debugger Delve API via flags

lambci / docker-lambda

Docker images and test runners that replicate the live AWS Lambda environment

MIT License

5.83k stars 431 forks source link

bump Go debugger Delve API via flags #170

Closed jackmcguire1 closed 5 years ago

jackmcguire1 commented 5 years ago

Configure Delve API version via flags, which has a default value of '1' for backwards compatibility.

There is now a lot of interest in running the Delve debugger with API version '2' Debugging go functions works with VS Code but not Goland.

We are all now aware VSC and other IDEs support this newer Devle API version.

This pull request is addressing the out-standing comments left within the PR (#131) raised, which have been unaddressed for 3+ months.

jackmcguire1 commented 5 years ago

@mhart please address as soon as possible!

mhart commented 5 years ago

Hey @jackmcguire1 thanks for this – will check it out today.

I don't really appreciate the urgency tbh – it's not a security fix, and this is a project I try to manage in my spare time – it's considered bad form to press open source maintainers like this.

jackmcguire1 commented 5 years ago

Apologies @mhart, I was none the wiser.

Appreciate everything you have done so far.

mhart commented 5 years ago

I'm kinda regretting that camel-case was introduced for these delve command-line flags, but oh well, that ship has sailed.

This looks good to me! Will merge and update once this has been pushed

mhart commented 5 years ago

Ugh.

https://status.docker.com/

mhart commented 5 years ago

I think it's been updated. It certainly appears to have been here: https://hub.docker.com/r/lambci/lambda/tags