set BUNDLE_SILENCE_ROOT_WARNING=1 for all ruby container

lambci / docker-lambda

Docker images and test runners that replicate the live AWS Lambda environment

MIT License

5.82k stars 431 forks source link

set BUNDLE_SILENCE_ROOT_WARNING=1 for all ruby container #286

Closed timoschilling closed 4 years ago

timoschilling commented 4 years ago

This change suppress the "Don't run Bundler as root" warning, this config it's used by the official ruby dockerfile as well.

Don't run Bundler as root. Bundler can ask for sudo if it is needed,
and installing your bundle as root will break this application for all non-root users on this machine.

mhart commented 4 years ago

Thanks for the contribution – this looks great!

Can you remove them from the run images? These are intended to match Lambda as closely as possible and this environment variable isn't set in Lambda

timoschilling commented 4 years ago

sure, as I read the Dockerfile again they don't make sense in run because of it runs as USER sbx_user1051

mhart commented 4 years ago

Merging!