lambci / docker-lambda

Docker images and test runners that replicate the live AWS Lambda environment
MIT License
5.83k stars 431 forks source link

Add Github Actions build #309

Closed gliptak closed 3 years ago

gliptak commented 3 years ago

https://github.com/gliptak/docker-lambda/pull/1/checks?check_run_id=1166239653

gliptak commented 3 years ago

@mhart please review

mhart commented 3 years ago

Can you elaborate?

gliptak commented 3 years ago

After this PR is merged, the build can be updated to build all Dockerfiles in the project ensuring that build process is successful (running on all PRs and master commits)

mhart commented 3 years ago

There's already a build script to build all the images, you can use that if you like: https://github.com/lambci/docker-lambda/blob/master/base/build-all.sh

gliptak commented 3 years ago

@mhart running https://github.com/lambci/docker-lambda/blob/master/base/build-all.sh runs out-of-space https://github.com/gliptak/docker-lambda/runs/1171597286?check_suite_focus=true

mhart commented 3 years ago

Yeah, there are 40 images now – I guess GH Actions can't do this out of the box

gliptak commented 3 years ago

Separating into two builds works https://github.com/gliptak/docker-lambda/pull/1/checks?check_run_id=1172828830 https://github.com/gliptak/docker-lambda/pull/1/checks?check_run_id=1172828834

gliptak commented 3 years ago

Runs are green https://github.com/gliptak/docker-lambda/pull/1/checks?check_run_id=1173396166 https://github.com/gliptak/docker-lambda/pull/1/checks?check_run_id=1173396168

gliptak commented 3 years ago

@mhart any other updates you would need to see?

mhart commented 3 years ago

All good, thanks @gliptak !