lambci / docker-lambda

Docker images and test runners that replicate the live AWS Lambda environment
MIT License
5.84k stars 431 forks source link

Make images available in the AWS ECR Public Gallery #326

Open tomcrawf90 opened 3 years ago

tomcrawf90 commented 3 years ago

Would it be possible to get this image made available on the AWS ECR Public Gallery? This would help avoid the issue of rate limiting implemented by DockerHub especially when running in CI/CD and on shared infrastructure.

zoellner commented 3 years ago

Came here to ask for the same. Given the timing it looks to me like Docker started to restrict AWS CodeBuild/CodePipeline IPs more now

edit: in the meanwhile, I created a temporary registry to host the image I need. let me know if anyone wants me to push another image. https://gallery.ecr.aws/n8r6f1x4/lambci-temporary

laynr commented 3 years ago

Came here to ask for the same. Given the timing it looks to me like Docker started to restrict AWS CodeBuild/CodePipeline IPs more now

edit: in the meanwhile, I created a temporary registry to host the image I need. let me know if anyone wants me to push another image. https://gallery.ecr.aws/n8r6f1x4/lambci-temporary

@zoellner please add python 3.8

edit: I see https://gallery.ecr.aws/lambda/python ... I will give that one a try, I am not sure what is now implemented by Amazon.

zoellner commented 3 years ago

Added

public.ecr.aws/n8r6f1x4/lambci-temporary:python3.8
sha256:bbdb78040d8067bac553dfa1b5e8b2f14e9771980b39a3325c8323b302bf1ea5

and

public.ecr.aws/n8r6f1x4/lambci-temporary:build-python3.8
sha256:d944b5ae251d24a089c4cc8c889e861cca6ce0ea0da376c364eeebe9ea4cce58

Depending on what you want to do that AWS image might work fine. In my experience they're good to run stuff but if you want to build things it doesn't work well since they've stripped it down too much for that. My experience is from nodejs only however, might be different in the python world.

kristianpaul commented 3 years ago

Any plans to add some older python version images as well?

zoellner commented 3 years ago

no plans to add anything from my side since I got what I need. but if you have a particular image you need, let me know and I'll add it

kristianpaul commented 3 years ago

no plans to add anything from my side since I got what I need. but if you have a particular image you need, let me know and I'll add it

lambci/lambda:build-python3.6

zoellner commented 3 years ago

Added

public.ecr.aws/n8r6f1x4/lambci-temporary:build-python3.6
sha256:a977ca47a1ee77735c83ca3d994293dc431c3655daca42ce1e9ba546963c7d8c
rexm commented 3 years ago

Can you please add lambci/lambda:java8?

zoellner commented 3 years ago

Added

public.ecr.aws/n8r6f1x4/lambci-temporary:java8
sha256:46f0df6293fd8b92274b7b0081bcafadda4dfb4b9bf29196f13b88415c0bb1d7
rexm commented 3 years ago

A bit embarrassing, but can you please also add:

zoellner commented 3 years ago

Added

public.ecr.aws/n8r6f1x4/lambci-temporary:nodejs6.10
sha256:27aba2358e8cace3a830f29bef1f7e8d10a2cfff151712b166c19bd7b86a8a82
public.ecr.aws/n8r6f1x4/lambci-temporary:nodejs8.10
sha256:f3a37b9fc2afcdf63dd8741c48d9b3f9ed0892eed8c490dd50ac7dcc75f7aee3
public.ecr.aws/n8r6f1x4/lambci-temporary:python3.7
sha256:98aa6d05a076ed08395e2ad62f119df6a9362aa0f59ac616396f924cee3f59f6

@rexm I hope you're not using those node versions in public anymore 🙈

rexm commented 3 years ago

It’s in some old local dev stuff we are upgrading :) thanks!

rexm commented 3 years ago

Can you please add lambci/lambda:go1.x?

zoellner commented 3 years ago

here you go:

public.ecr.aws/n8r6f1x4/lambci-temporary:go1.x
zacthompson commented 3 years ago

🥺 lambci/lambda:java11 ?

zoellner commented 2 years ago

I added that at public.ecr.aws/n8r6f1x4/lambci-temporary:java11 (forgot to mention it here)

zacthompson commented 2 years ago

I added that at public.ecr.aws/n8r6f1x4/lambci-temporary:java11 (forgot to mention it here)

Yes, I saw, could only react to my own comment at the time. Thank you kindly

ohalay commented 2 years ago

@zoellner Can you please add lambci/lambda:dotnetcore3.1?

zoellner commented 2 years ago

Added

public.ecr.aws/n8r6f1x4/lambci-temporary:dotnetcore3.1
sha256:4ee19e6a9647fb744c3cd9c9701c1bedc6a9bf3b47e5a983766819cc92bbb829
ohalay commented 2 years ago

@zoellner Could you also add build version lambci/lambda:build-dotnetcore3.1

zoellner commented 2 years ago

done

public.ecr.aws/n8r6f1x4/lambci-temporary:build-dotnetcore3.1
sha256:c85835597ffb1952840a62551cd09eb1e58df02e38401fd188b60114b345c6a7
rexm commented 2 years ago

@zoellner Hey there! Can you please mirror nodejs12.x?

zoellner commented 2 years ago
public.ecr.aws/n8r6f1x4/lambci-temporary:nodejs12.x
digest: sha256:098709a2d12098c2ab5ad45138a2f97d3acc1788c2855b3659dd20eed62fd2af