search

lambci / lambci

A continuous integration system built on AWS Lambda
https://medium.com/@hichaelmart/lambci-4c3e29d6599b
MIT License
4k stars 193 forks source link

GitHub Enterprise support #16

Open jhurliman opened 8 years ago

jhurliman commented 8 years ago

This is partially, but not quite, working with GitHub Enterprise. Would love the ability to specify a GitHub Enterprise URL in the CloudFormation setup.

jhurliman commented 8 years ago

lambci/sources/github.js will need a bit of tweaking for this, since Enterprise uses a single hostname for both the web frontend and the API. It follows the form https://{hostname}/api/v3/

mhart commented 8 years ago

@jhurliman interesting – is there any documentation on this? Or is the hostname literally the only difference?

It would certainly be straightforward to add this as a config param – which could be administered like the others, via the command line, etc. I'm wary of adding it to the cloudformation template just because I don't want the list of params to start blowing out – although perhaps I could just create a separate lambci-enterprise.template that includes it.

jhurliman commented 8 years ago

https://developer.github.com/v3/enterprise/

Whatever works! I don't have a specific preference, just looking forward to using this.

wonderdogone commented 8 years ago

+1 for this. We have some great use cases for this but need to use our Enterprise accounts for obvious reasons.

harakiro commented 8 years ago

+1 for adding this as well. I went through the code to see where to add this and it seems it would be much easier for you to do it here as the CF template pulls the source from your s3 bucket.

Likely two useful additions would be the ability to provide the optional param here, additionally the ability to provide the S3 bucket to pull lambci code from rather than the version. Had this been there it would have been much easier for me to make the above changes. As it stands, even if I made the changes, I'll need to alter other deployment details.

Not be critical by any means, this is amazing work and super excited to use, and help out.

hawkins commented 4 years ago

I hate to even ask, but with 3 years since the last bump, has the outlook on GitHub Enterprise support changed?

mhart commented 4 years ago

PRs welcome here. I don't have access to GitHub Enterprise, so it's pretty hard for me to develop for it.