search

lambda-fairy / maud

:pencil: Compile-time HTML templates for Rust
https://maud.lambda.xyz
Apache License 2.0
1.98k stars 132 forks source link

impl Default for PreEscaped #371

Closed imbolc closed 1 year ago

imbolc commented 1 year ago

Tests was broken before the change, I'm not sure if I should fix them. But cargo test misc works.

imbolc commented 1 year ago

Also I noticed seemingly unnecessary type restriction: struct PreEscaped<T: AsRef<str>>(pub T). I believe removing the AsRef restriction won't change any behavior, but it won't be necessary to repeat the restriction in each implementation. I can remove it in this PR if you'd like.

lambda-fairy commented 1 year ago

Thanks!

I believe removing the AsRef restriction won't change any behavior, but it won't be necessary to repeat the restriction in each implementation. I can remove it in this PR if you'd like.

That sounds like a good change. Though I'd prefer that in a separate PR, just to keep things small.

That reminds me, I should polish up #322 again...