search

lambda-fairy / maud

:pencil: Compile-time HTML templates for Rust
https://maud.lambda.xyz
Apache License 2.0
1.98k stars 132 forks source link

Support `axum` v0.7 through `axum-core` v0.4 and `http` v1 #401

Closed vidhanio closed 6 months ago

vidhanio commented 7 months ago

closes #402

vidhanio commented 7 months ago

8th time's the charm i guess, LOL

philipcristiano commented 7 months ago

@lambda-fairy are you able to take a look?

evgenykobz commented 6 months ago

Apparently, this breaking change broke the latest v. of Maud:

breaking: The response returned by IntoResponse::into_response must use axum::body::Body as the body type. axum::response::Response does this.

vidhanio commented 6 months ago

Apparently, this breaking change broke the latest v. of Maud:

breaking: The response returned by IntoResponse::into_response must use axum::body::Body as the body type. axum::response::Response does this.

not just that. it's a semver-incompatible version bump which means the types are no longer compatible across projects with axum 0.6 as their dep vs axum 0.7.

10ne1 commented 6 months ago

Gentle ping - it would be awesome if this could land. Thanks!

jryio commented 6 months ago

Likewise. I am currently pulling the forked branch into my project(s) to use with axum 0.7 (everything is working correctly so far) - thanks!

lambda-fairy commented 6 months ago

Thanks for the patience!

philipcristiano commented 5 months ago

@lambda-fairy any chance you could release a new version to crates.io now that this has been merged?

lambda-fairy commented 5 months ago

@philipcristiano I'll likely get to it this weekend. In the meantime, using a git dependency (like you've done) is good and supported.

I've been thinking about the literals-in-attribute-names proposal (#396 + #398). I don't feel comfortable releasing that in its current state. I want to collect my thoughts and decide whether to revert or polish that up first.

jryio commented 5 months ago

Grateful for your work on this crate @lambda-fairy! Thank you!

lambda-fairy commented 5 months ago

https://crates.io/crates/maud/0.26.0